Grammar issue on the error message

pei.wang · June 12, 2023, 8:21am

Hi there,
Could you help to correct the grammar in this error message?
Should be either THE CREDENTIAL HAS EXPIRED or THE CREDENTIALS HAVE EXPIRED ?

github.com

auth0/auth0-guardian.js/blob/master/lib/errors/credentials_expired_error.js

'use strict';

var object = require('../utils/object');
var GuardianError = require('./guardian_error');

function CredentialsExpiredError() {
  GuardianError.call(this, {
    message: 'The credentials has expired.',
    errorCode: 'credentials_expired'
  });
}

CredentialsExpiredError.prototype = object.create(GuardianError.prototype);
CredentialsExpiredError.prototype.constructor = CredentialsExpiredError;

module.exports = CredentialsExpiredError;

CleanShot 2023-06-12 at 20.16.40

konrad.sopala · June 13, 2023, 10:50am

Hey there!

In order to handle that most effectively can I ask you to raise it in a GitHub issue there so we can work on that directly with the repo maintainers?

Once you have a link to it please share it here so we can ping them. Thank you!

pei.wang · June 18, 2023, 11:58pm

Hi Konrad,
Thanks for replying. I raised an issue on the repo.

github.com/auth0/auth0-guardian.js

Grammar issue on the error message

opened 11:01PM - 18 Jun 23 UTC

pei-wang

### Description We noticed a grammar issue on the Auth0 widget. should be eithe…r `THE CREDENTIAL HAS EXPIRED` or `THE CREDENTIALS HAVE EXPIRED` ? ![image](https://github.com/auth0/auth0-guardian.js/assets/7090689/d2255c2e-5d27-4084-a9e2-9b269a90e400) The source code is located at https://github.com/auth0/auth0-guardian.js/blob/master/lib/errors/credentials_expired_error.js Actually, we are using https://cdn.auth0.com/js/mfa-widget/mfa-widget-1.8.min.js I am wondering if you correct the grammar on auth0-guardian.js, how could we pick it up? what's the relationship between auth0-guradian.js and mfa-widget? I rarely see the docs related to mfa-widget on auth0 official site. ### Reproduction N/A ### Environment - **Version of this library used:** - **Version of the platform or framework used, if applicable:** - **Other relevant versions (language, server software, OS, browser):** - **Other modules/plugins/libraries that might be involved:**

konrad.sopala · June 19, 2023, 11:26am

Perfect thanks! I’ll ping repo maintainers in a few minutes!

system · July 3, 2023, 11:26am

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.